----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53999/#review156646 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Nov. 22, 2016, 8:49 p.m., Swapan Shridhar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53999/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2016, 8:49 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Sumit Mohanty. > > > Bugs: AMBARI-18963 > https://issues.apache.org/jira/browse/AMBARI-18963 > > > Repository: ambari > > > Description > ------- > > **Issue:** > - Currently, we calculate config 'hive.llap.io.memory.size' value in MB. > - We end up writing the config value in MB units to hive-site.xml. > > **Expected:** > - Value written in hive-site.xml should be in Bytes. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_interactive.py > fa6d6a0 > > Diff: https://reviews.apache.org/r/53999/diff/ > > > Testing > ------- > > **Manual testing done.** > > From HSI start logs: > > ------------------------------------------------------------------------------------------------------------------------------------- > **cache value used ->>>> 14336m** > > 2016-11-22 20:27:28,788 - Command: > /usr/hdp/current/hive-server2-hive2/bin/hive --service llap --instances 1 > --slider-am-container-mb 3584 --size 17920m --cache 14336m --xmx 2867m > --loglevel INFO --output > /var/lib/ambari-agent/tmp/llap-slider2016-11-22_20-27-28 --args " > -XX:+AlwaysPreTouch -XX:+UseG1GC -XX:TLABSize=8m -XX:+ResizeTLAB -XX:+UseNUMA > -XX:+AggressiveOpts -XX:MetaspaceSize=1024m > -XX:InitiatingHeapOccupancyPercent=80 -XX:MaxGCPauseMillis=200" > > **cache value written ->>>> 15032385536 Bytes** > > 2016-11-22 20:27:28,178 - Converted 'hive.llap.io.memory.size' value from > '14336 MB' to '15032385536 Bytes' before writing config to Config file. > > ------------------------------------------------------------------------------------------------------------------------------------- > > In /etc/hive2/conf/hive-site.xml: > > <property> > <name>hive.llap.io.memory.size</name> > <value>15032385536</value> > </property> > > > Thanks, > > Swapan Shridhar > >
