-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54161/#review157237
-----------------------------------------------------------




ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
 (line 160)
<https://reviews.apache.org/r/54161/#comment227772>

    I think its possible that different KDC is used for different cluster so 
for that we will need external properties for principal/keytab etc.



ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
<https://reviews.apache.org/r/54161/#comment227770>

    maybe we can keep this here, i mean if there is infra-solr installed, maybe 
that is used. (if there is no infra-solr on the cluster then i guess it wont 
have any effect)



ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 (line 114)
<https://reviews.apache.org/r/54161/#comment227773>

    I think stack advisor changes are missing. at least it would be nice if it 
reccommend us some configuration in case we do not have infra-solr


- Oliver Szabo


On Nov. 29, 2016, 1:03 p.m., Miklos Gergely wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54161/
> -----------------------------------------------------------
> 
> (Updated Nov. 29, 2016, 1:03 p.m.)
> 
> 
> Review request for Ambari, Oliver Szabo, Robert Nettleton, and Sumit Mohanty.
> 
> 
> Bugs: AMBARI-19012
>     https://issues.apache.org/jira/browse/AMBARI-19012
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users can install LogSearch now without zookkeper or solr, using an external 
> server instead. If AMBARI_INFRA is present then the user may choose to use 
> it, or an external solr.
> 
> 
> Diffs
> -----
> 
>   
> ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py
>  8257022 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml
>  c5b9b4e 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 
> 6d1cf38 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
>  bdb0c10 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py
>  021c167 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
>  6c1a936 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/output.config.json.j2
>  ff43323 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2
>  2818708 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2
>  eb7306c 
>   
> ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/themes/theme.json
>  0193689 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json c3eba53 
>   ambari-web/app/data/HDP2/site_properties.js d61d4aa 
> 
> Diff: https://reviews.apache.org/r/54161/diff/
> 
> 
> Testing
> -------
> 
> Tested on local cluster.
> 
> 
> Thanks,
> 
> Miklos Gergely
> 
>

Reply via email to