----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54207/#review157456 -----------------------------------------------------------
ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py (line 31) <https://reviews.apache.org/r/54207/#comment228050> Do we need an empty check for "all_collectors_string" here ? - Aravindan Vijayan On Nov. 30, 2016, 4:32 p.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54207/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2016, 4:32 p.m.) > > > Review request for Ambari, Aravindan Vijayan and Sid Wagle. > > > Bugs: AMBARI-19032 > https://issues.apache.org/jira/browse/AMBARI-19032 > > > Repository: ambari > > > Description > ------- > > HDFS Metric alerts turns to UNKNOWN state with error "'NoneType' object has > no attribute 'split'". > STR: > Update the alert definition interval to 1 min, and thresholds to have minimum > values to trigger the Alert. > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py > 7b4e8f5 > > ambari-metrics/ambari-metrics-common/src/main/java/org/apache/hadoop/metrics2/sink/timeline/AbstractTimelineMetricsSink.java > 769d0c1 > > ambari-metrics/ambari-metrics-common/src/test/java/org/apache/hadoop/metrics2/sink/timeline/availability/AbstractTimelineMetricSinkTest.java > 5e016f8 > > ambari-metrics/ambari-metrics-hadoop-sink/src/main/java/org/apache/hadoop/metrics2/sink/timeline/HadoopTimelineMetricsSink.java > 802e684 > > ambari-server/src/main/resources/common-services/ACCUMULO/1.6.1.2.2.0/package/scripts/params.py > e00c1f5 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > e278d0d > > ambari-server/src/main/resources/common-services/FLUME/1.4.0.2.0/package/scripts/params.py > 008e9d6 > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/package/scripts/params_linux.py > 1f32c41 > > ambari-server/src/main/resources/common-services/HDFS/2.1.0.2.0/package/alerts/alert_metrics_deviation.py > 4efdae5 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/params_linux.py > 01e5f00 > > ambari-server/src/main/resources/common-services/KAFKA/0.8.1/package/scripts/params.py > 0cb88fe > > ambari-server/src/main/resources/common-services/STORM/0.9.1/package/scripts/params_linux.py > e753e98 > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > 4603c8b > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py > 7cd9340 > > Diff: https://reviews.apache.org/r/54207/diff/ > > > Testing > ------- > > Unit tests passed. > > > Thanks, > > Dmytro Sen > >
