-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54252/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Attila Magyar, Jayush Luniya, 
Laszlo Puskas, Sumit Mohanty, and Sebastian Toader.


Repository: ambari


Description
-------

Data model and JSON parser.


Diffs
-----

  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/LinkNameFilter.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 PRE-CREATION 
  
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java
 PRE-CREATION 
  
ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
 f44f741 
  
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
 PRE-CREATION 
  ambari-server/src/test/resources/example_quicklinks_profile.json PRE-CREATION 
  ambari-server/src/test/resources/inconsistent_quicklinks_profile.json 
PRE-CREATION 

Diff: https://reviews.apache.org/r/54252/diff/


Testing
-------

- Wrote new unit tests
- Run the tests for Ambari-server. Failures are irrelevant.

Failed tests:
  UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1118
  Unexpected method call 
AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface 
org.apache.ambari.server.state.Cluster, EasyMock for interface 
org.apache.ambari.server.state.Service):
    AmbariManagementController.getClusters(): expected: at least 0, actual: 1
    AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for 
interface org.apache.ambari.server.state.Cluster, EasyMock for interface 
org.apache.ambari.server.state.Service): expected: 1, actual: 0
  DataStoreImplTest.testFind:526 expected:<class 
DS_DataStoreImplTest$TestEntity_1> but was:<class 
DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testRemove:475 expected:<class 
DS_DataStoreImplTest$TestEntity_1> but was:<class 
DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update:357 expected:<class 
DS_DataStoreImplTest$TestEntity_1> but was:<class 
DS_DataStoreImplTest$TestSubEntity_1>
  DataStoreImplTest.testStore_update_longStringValue:426
  Expectation failure on verify:
    DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
Tests in error:
  KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
expected<org.apac...
  KerberosCheckerTest.testCheckPassed:62 » ClassCast class 
sun.security.provider...

Tests run: 4785, Failures: 5, Errors: 4, Skipped: 37


Thanks,

Balázs Bence Sári

Reply via email to