-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54252/#review157638
-----------------------------------------------------------




ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
 (line 31)
<https://reviews.apache.org/r/54252/#comment228266>

    typo: "applies a to" -> "applies to"



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
 (line 32)
<https://reviews.apache.org/r/54252/#comment228267>

    typo: "if the visibility" -> "the visibility"



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/LinkNameFilter.java
 (line 31)
<https://reviews.apache.org/r/54252/#comment228271>

    "link_name" should be extracted to a constant (eg. PROPERTY_NAME), to be 
reused in the parser.



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/LinkNameFilter.java
 (line 57)
<https://reviews.apache.org/r/54252/#comment228253>

    `Objects` is already imported, no need to use fully qualified name.



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java
 (line 30)
<https://reviews.apache.org/r/54252/#comment228272>

    "property_name" should be extracted to a constant (eg. PROPERTY_NAME), to 
be reused in the parser.



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java
 (line 56)
<https://reviews.apache.org/r/54252/#comment228254>

    `Objects` is already imported, no need to use fully qualified name.



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 (line 39)
<https://reviews.apache.org/r/54252/#comment228264>

    Could be final.



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 (line 70)
<https://reviews.apache.org/r/54252/#comment228255>

    typo: "polimorphism" -> "polymorphism"



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 (line 72)
<https://reviews.apache.org/r/54252/#comment228270>

    typo: "converted parsed as" -> "converted to" or "parsed as"



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 (line 78)
<https://reviews.apache.org/r/54252/#comment228262>

    typo: "ambigous" -> "ambiguous"



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 (line 81)
<https://reviews.apache.org/r/54252/#comment228261>

    `throws IOEXception` does not match `@throws JsonParseException`



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 (lines 88 - 89)
<https://reviews.apache.org/r/54252/#comment228258>

    Please add braces {}



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 (lines 93 - 94)
<https://reviews.apache.org/r/54252/#comment228259>

    Please add braces {}



ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
 (lines 99 - 100)
<https://reviews.apache.org/r/54252/#comment228260>

    Please add braces {}



ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
 (line 21)
<https://reviews.apache.org/r/54252/#comment228279>

    `import *` should be avoided.



ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
 (line 71)
<https://reviews.apache.org/r/54252/#comment228274>

    Could be simplified by declaring expected exception as `@Test(expected = 
JsonParseException.class)` and getting rid of try+catch+fail.


- Attila Doroszlai


On Dec. 1, 2016, 3:25 p.m., Balázs Bence Sári wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54252/
> -----------------------------------------------------------
> 
> (Updated Dec. 1, 2016, 3:25 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Attila Magyar, Jayush Luniya, 
> Laszlo Puskas, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-18978
>     https://issues.apache.org/jira/browse/AMBARI-18978
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Data model and JSON parser.
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/AcceptAllFilter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Component.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Filter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/LinkNameFilter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/PropertyFilter.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParser.java
>  PRE-CREATION 
>   
> ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/Service.java
>  PRE-CREATION 
>   
> ambari-server/src/test/java/org/apache/ambari/server/stack/QuickLinksConfigurationModuleTest.java
>  f44f741 
>   
> ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
>  PRE-CREATION 
>   ambari-server/src/test/resources/example_quicklinks_profile.json 
> PRE-CREATION 
>   ambari-server/src/test/resources/inconsistent_quicklinks_profile.json 
> PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/54252/diff/
> 
> 
> Testing
> -------
> 
> - Wrote new unit tests
> - Run the tests for Ambari-server. Failures are irrelevant.
> 
> Failed tests:
>   UpgradeCatalog222Test.testInitializeStromAndKafkaWidgets:1118
>   Unexpected method call 
> AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for interface 
> org.apache.ambari.server.state.Cluster, EasyMock for interface 
> org.apache.ambari.server.state.Service):
>     AmbariManagementController.getClusters(): expected: at least 0, actual: 1
>     AmbariManagementController.initializeWidgetsAndLayouts(EasyMock for 
> interface org.apache.ambari.server.state.Cluster, EasyMock for interface 
> org.apache.ambari.server.state.Service): expected: 1, actual: 0
>   DataStoreImplTest.testFind:526 expected:<class 
> DS_DataStoreImplTest$TestEntity_1> but was:<class 
> DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testRemove:475 expected:<class 
> DS_DataStoreImplTest$TestEntity_1> but was:<class 
> DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update:357 expected:<class 
> DS_DataStoreImplTest$TestEntity_1> but was:<class 
> DS_DataStoreImplTest$TestSubEntity_1>
>   DataStoreImplTest.testStore_update_longStringValue:426
>   Expectation failure on verify:
>     DynamicEntity.set("DS_id", 99): expected: 1, actual: 0
> Tests in error:
>   KerberosCheckerTest.testCheckFailed »  Unexpected exception, 
> expected<org.apac...
>   KerberosCheckerTest.testCheckPassed:62 » ClassCast class 
> sun.security.provider...
> 
> Tests run: 4785, Failures: 5, Errors: 4, Skipped: 37
> 
> 
> Thanks,
> 
> Balázs Bence Sári
> 
>

Reply via email to