> On Dec. 1, 2016, 7:07 p.m., Alejandro Fernandez wrote: > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py, > > line 191 > > <https://reviews.apache.org/r/54259/diff/1/?file=1574285#file1574285line191> > > > > If there's a dash, then we should have at least one number after it. > > > > ([\d.]+(-\d+)?) > > > > If you do this, then need to change it to > > "if matches and len(matches) == 2:"
Hello Alejandro, Thanks for pointing that out. I modified the regex accordingly, also len(matches)=2 was causing due to grouping. So I modified it so that it does not return sub groups from the string and we get only one string with complete version number. So We don't have to modify the IF condition. - Amruta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54259/#review157628 ----------------------------------------------------------- On Dec. 1, 2016, 6:13 p.m., Amruta Borkar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54259/ > ----------------------------------------------------------- > > (Updated Dec. 1, 2016, 6:13 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Di Li. > > > Bugs: AMBARI-19039 > https://issues.apache.org/jira/browse/AMBARI-19039 > > > Repository: ambari > > > Description > ------- > > In stack version, build number should not be mandatory. mapreduce.tar.gz file > does not get copied during blueprint deployment when stack version does not > have build version. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/copy_tarball.py > 519c88b > > ambari-common/src/main/python/resource_management/libraries/functions/dynamic_variable_interpretation.py > ca8fe19 > > Diff: https://reviews.apache.org/r/54259/diff/ > > > Testing > ------- > > Test manually with stack version with build number and without build number. > > > Thanks, > > Amruta Borkar > >
