----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54334/#review157884 -----------------------------------------------------------
Ship it! Ship It! - Sid Wagle On Dec. 3, 2016, 2:24 a.m., Jonathan Hurley wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54334/ > ----------------------------------------------------------- > > (Updated Dec. 3, 2016, 2:24 a.m.) > > > Review request for Ambari. > > > Bugs: AMBARI-19073 > https://issues.apache.org/jira/browse/AMBARI-19073 > > > Repository: ambari > > > Description > ------- > > {{contrib/views/ambari-views-package/pom.xml}} has the wrong version defined > which can cause build failures under certain conditions. The parent POM from > {{contrib/views/pom.xml}} defines 2.0.0.0.0 while > {{contrib/views/ambari-views-package/pom.xml}} defines 2.5.0.0.0. > > {code} > git diff pom.xml > diff --git a/contrib/views/ambari-views-package/pom.xml > b/contrib/views/ambari-views-package/pom.xml > index cb070e6..16c9985 100644 > --- a/contrib/views/ambari-views-package/pom.xml > +++ b/contrib/views/ambari-views-package/pom.xml > @@ -26,7 +26,7 @@ > <parent> > <groupId>org.apache.ambari.contrib.views</groupId> > <artifactId>ambari-contrib-views</artifactId> > - <version>2.5.0.0.0</version> > + <version>2.0.0.0-SNAPSHOT</version> > </parent> > {code} > > This now matches {{contrib/views/pom.xml}}:} > {code} > <project xmlns="http://maven.apache.org/POM/4.0.0"; > xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; > xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 > http://maven.apache.org/maven-v4_0_0.xsd";> > <parent> > <groupId>org.apache.ambari</groupId> > <artifactId>ambari-project</artifactId> > <version>2.0.0.0-SNAPSHOT</version> > <relativePath>../../ambari-project</relativePath> > </parent> > {code} > > > Diffs > ----- > > contrib/views/ambari-views-package/pom.xml cb070e6 > > Diff: https://reviews.apache.org/r/54334/diff/ > > > Testing > ------- > > > Thanks, > > Jonathan Hurley > >
