----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54403/#review158137 -----------------------------------------------------------
Ship it! Ship It! - Dmytro Sen On Дек. 6, 2016, 12:42 д.п., Aravindan Vijayan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54403/ > ----------------------------------------------------------- > > (Updated Дек. 6, 2016, 12:42 д.п.) > > > Review request for Ambari, Dmytro Sen, Sumit Mohanty, and Sid Wagle. > > > Bugs: AMBARI-19101 > https://issues.apache.org/jira/browse/AMBARI-19101 > > > Repository: ambari > > > Description > ------- > > AMBARI-17457 was missed while backporting AMS HA commits into branch-2.5. > Hence, service_check.py for AMS in branch-2.5 and trunk are different. No AMS > HA support for service_check in branch-2.5. > > Applied AMBARI-17457 patch, and made changes to so that the service check and > Grafana datasource creation is compatible with changes introduced through > AMBARI-19032. > > Part of these changes may be checked into trunk as well, to maintain parity. > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/ambari_metrics_helper.py > 10eb660 > ambari-common/src/main/python/ambari_commons/parallel_processing.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/metrics_grafana_util.py > 7c2f2df > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/params.py > 684c312 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/scripts/service_check.py > ddd3e42 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/package/templates/metrics_grafana_datasource.json.j2 > 678d769 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/hooks/before-START/scripts/params.py > a22eb90 > > Diff: https://reviews.apache.org/r/54403/diff/ > > > Testing > ------- > > Manually tested. > > > Thanks, > > Aravindan Vijayan > >
