----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54431/#review158199 -----------------------------------------------------------
ambari-common/src/main/python/ambari_commons/logging_utils.py (line 70) <https://reviews.apache.org/r/54431/#comment228969> I would call this param "force=False" instead. if force: print ... return if _VERBOSE: print - Alejandro Fernandez On Dec. 6, 2016, 6:14 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54431/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 6:14 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Tim Thorpe. > > > Bugs: AMBARI-19111 > https://issues.apache.org/jira/browse/AMBARI-19111 > > > Repository: ambari > > > Description > ------- > > Ambari server upgrade log printout refactoring with the INFO header for info > level logs and print INFO log that should be there regardless whether verbose > is set. > > > Diffs > ----- > > ambari-common/src/main/python/ambari_commons/logging_utils.py 4ebe696 > ambari-server/src/main/python/ambari_server/serverUpgrade.py 7d7a9ab > > Diff: https://reviews.apache.org/r/54431/diff/ > > > Testing > ------- > > existing unit testing > patch a trunk cluster with the changes and run ambari-server upgrade cmd, > verify that more INFO level log printout is shown. > > > Thanks, > > Di Li > >
