----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53727/#review158261 -----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-tagsync-site.xml (line 22) <https://reviews.apache.org/r/53727/#comment229044> ranger.tagsync.dest.ranger.ssl.config.filename is a property that is being edited. This means that the following upgrade packs need to change 2.4->2.6 RU 2.4->2.6 EU 2.5->2.6 RU 2.5->2.6 EU Each upgrade pack will need to make config changes to set the property with the new value. This means that in the config packs whose source version is HDP 2.4 and 2.5 will need a new configuration group with a unique ID that can be referenced. ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml (line 26) <https://reviews.apache.org/r/53727/#comment229042> This doesn't look correct. HDP 2.6 should inherit from 2.5, otherwise, we'll miss everything from HDP 2.0.6, 2.1, 2.2, 2.3, 2.4, 2.5 - Alejandro Fernandez On Dec. 6, 2016, 4:02 p.m., Vishal Suvagia wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53727/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 4:02 p.m.) > > > Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jaimin Jetly, > Jayush Luniya, Mugdha Varadkar, and Velmurugan Periasamy. > > > Bugs: AMBARI-18874 > https://issues.apache.org/jira/browse/AMBARI-18874 > > > Repository: ambari > > > Description > ------- > > Need to provide ssl related configurations for Ranger-Tagsync service. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/constants.py > 46562e0 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/params.py > f2cc940 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/ranger_tagsync.py > 9c6e142 > > ambari-server/src/main/resources/common-services/RANGER/0.4.0/package/scripts/setup_ranger_xml.py > 8036f28 > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/atlas-tagsync-ssl.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-policymgr-ssl.xml > PRE-CREATION > > ambari-server/src/main/resources/common-services/RANGER/0.7.0/configuration/ranger-tagsync-site.xml > PRE-CREATION > ambari-server/src/main/resources/common-services/RANGER/0.7.0/metainfo.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.0.6/properties/stack_features.json > 27a755c > > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/nonrolling-upgrade-2.6.xml > 66f872d > ambari-server/src/main/resources/stacks/HDP/2.5/upgrades/upgrade-2.6.xml > 1f7c1a8 > > ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/configuration/ranger-tagsync-site.xml > PRE-CREATION > > ambari-server/src/main/resources/stacks/HDP/2.6/services/RANGER/metainfo.xml > a115134 > ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_tagsync.py > PRE-CREATION > ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json > 1d5adff > ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json > 030b717 > > Diff: https://reviews.apache.org/r/53727/diff/ > > > Testing > ------- > > Tested Ranger with Tagsync installation on CentOS 6. > > Verified Unit-tests: > > test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:01:42,649 - Stack Feature Version Info: stack_version=2.6, > version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111 > 2016-11-17 20:01:42,670 - Stack Feature Version Info: stack_version=2.6, > version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111 > ok > test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... ok > test_start_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:01:42,691 - Stack Feature Version Info: stack_version=2.6, > version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111 > ok > test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:01:42,712 - Stack Feature Version Info: stack_version=2.6, > version=2.6.0.0-111, current_cluster_version=2.6.0.0-111 -> 2.6.0.0-111 > ok > > > test_configure_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:02:05,297 - Stack Feature Version Info: stack_version=2.5, > version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 > ok > test_configure_secured (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:02:05,318 - Stack Feature Version Info: stack_version=2.5, > version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 > ok > test_start_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:02:05,336 - Stack Feature Version Info: stack_version=2.5, > version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 > ok > test_stop_default (test_ranger_tagsync.TestRangerTagsync) ... 2016-11-17 > 20:02:05,355 - Stack Feature Version Info: stack_version=2.5, > version=2.5.0.0-801, current_cluster_version=2.5.0.0-801 -> 2.5.0.0-801 > ok > > > Thanks, > > Vishal Suvagia > >
