----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54406/#review158264 -----------------------------------------------------------
Ship it! Ship It! - Richard Zang On Dec. 6, 2016, 1:44 a.m., Xi Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54406/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2016, 1:44 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, and Yusaku Sako. > > > Bugs: AMBARI-19099 > https://issues.apache.org/jira/browse/AMBARI-19099 > > > Repository: ambari > > > Description > ------- > > In all wizard steps: > 1. should always show completed step markers in green, not grey. Even if > those steps were disabled. > 2. Summary and review page text line height. > 3. In "Assign Master" step, the green labels of components need more padding > 4. Wizard menu and content should be divided with a clean line, the line in > the red circle is not clean. This is because the background. > > > Diffs > ----- > > ambari-web/app/styles/theme/bootstrap-ambari.css d10a13b > ambari-web/app/styles/wizard.less 57dae45 > ambari-web/app/templates/wizard/step8.hbs 5c2e8e6 > > Diff: https://reviews.apache.org/r/54406/diff/ > > > Testing > ------- > > > Thanks, > > Xi Wang > >
