----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54476/#review158325 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java (line 292) <https://reviews.apache.org/r/54476/#comment229100> Can you add a unit test for this case? - Sebastian Toader On Dec. 7, 2016, 11:37 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54476/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2016, 11:37 a.m.) > > > Review request for Ambari, Oliver Szabo, Robert Nettleton, Sumit Mohanty, and > Sebastian Toader. > > > Bugs: AMBARI-19004 > https://issues.apache.org/jira/browse/AMBARI-19004 > > > Repository: ambari > > > Description > ------- > > If the ambari server calls the REST api of logsearch to get the log files, > and the call fails - for example the Log Search portal is not running - then > it caches it as "no log file" for the host component. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/logging/LogSearchDataRetrievalService.java > 1c135b2 > > Diff: https://reviews.apache.org/r/54476/diff/ > > > Testing > ------- > > Executed the test "ambari-logsearch" on an openstack cluster. > > > Thanks, > > Miklos Gergely > >
