-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54513/#review158494
-----------------------------------------------------------


Ship it!




Ship It!

- Sid Wagle


On Dec. 8, 2016, 12:39 a.m., Alejandro Fernandez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54513/
> -----------------------------------------------------------
> 
> (Updated Dec. 8, 2016, 12:39 a.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Swapan Shridhar, and Sid Wagle.
> 
> 
> Bugs: AMBARI-19137
>     https://issues.apache.org/jira/browse/AMBARI-19137
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create new versions in common-services for ZK, HDFS, YARN/MR and inherit from 
> them in HDP 3.0 TP
> 
> common-services is allowed to define
> 
> * kerberos.json
> * widgets
> * themes
> * configs
> 
> Create new version in common services
> ZK: 3.4.9, inherit from ZK 3.4.6 in common services
> HDFS: 3.0.0, copy every script/config/widget/theme/kerberos-descriptor from 
> the previous version in common-services and combine with the flattened files 
> from HDP 2.0.6 through HDP 2.6
> YARN/MR: 3.0.0, copy every script/config/widget/theme/kerberos-descriptor 
> from the previous version in common-services and combine with the flattened 
> files from HDP 2.0.6 through HDP 2.6
> 
> Finally, any configs with references to /usr/hdp must be replaced by 
> {{stack_root}, and configs that use ${hdp.version} must be overriden by the 
> HDP 3.0 stack and kept clean in the version used by common-services.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/core-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/hadoop-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/hadoop-metrics2.properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/hadoop-policy.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/hdfs-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/hdfs-logsearch-conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/hdfs-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/ranger-hdfs-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/ranger-hdfs-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/ranger-hdfs-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/ranger-hdfs-security.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/ssl-client.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/configuration/ssl-server.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0/metainfo.xml 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0/metrics.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/alerts/alert_checkpoint_time.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/alerts/alert_datanode_unmounted_data_dir.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/alerts/alert_ha_namenode_health.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/alerts/alert_metrics_deviation.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/alerts/alert_upgrade_finalized.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/files/checkWebUI.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/__init__.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/balancer-emulator/balancer-err.log
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/balancer-emulator/balancer.log
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/balancer-emulator/hdfs-command.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/datanode.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/datanode_upgrade.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/hdfs.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/hdfs_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/hdfs_datanode.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/hdfs_namenode.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/hdfs_nfsgateway.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/hdfs_rebalance.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/hdfs_snamenode.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/install_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/journalnode.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/journalnode_upgrade.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/namenode.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/namenode_ha_state.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/namenode_upgrade.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/nfsgateway.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/params_linux.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/params_windows.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/setup_ranger_hdfs.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/snamenode.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/utils.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/scripts/zkfc_slave.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/templates/exclude_hosts_list.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/templates/hdfs.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/package/templates/slaves.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/HDFS/3.0.0/themes/theme.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/HDFS/3.0.0/widgets.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/MAPREDUCE2_metrics.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/YARN_metrics.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/YARN_widgets.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/YARN/3.0.0/alerts.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration-mapred/mapred-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration-mapred/mapred-logsearch-conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration-mapred/mapred-site.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration/capacity-scheduler.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration/ranger-yarn-audit.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration/ranger-yarn-plugin-properties.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration/ranger-yarn-policymgr-ssl.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration/ranger-yarn-security.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration/yarn-env.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration/yarn-log4j.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration/yarn-logsearch-conf.xml
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/configuration/yarn-site.xml
>  PRE-CREATION 
>   ambari-server/src/main/resources/common-services/YARN/3.0.0/kerberos.json 
> PRE-CREATION 
>   ambari-server/src/main/resources/common-services/YARN/3.0.0/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/alerts/alert_nodemanager_health.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/alerts/alert_nodemanagers_summary.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/files/validateYarnComponentStatusWindows.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/__init__.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/application_timeline_server.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/historyserver.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/install_jars.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/mapred_service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/mapreduce2_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/nodemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/nodemanager_upgrade.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/params_linux.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/params_windows.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/resourcemanager.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/service.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/service_check.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/setup_ranger_yarn.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/status_params.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/yarn.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/scripts/yarn_client.py
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/templates/container-executor.cfg.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/templates/exclude_hosts_list.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/templates/mapreduce.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/templates/taskcontroller.cfg.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/package/templates/yarn.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/quicklinks-mapred/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/quicklinks/quicklinks.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/themes-mapred/theme.json
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0/themes/theme.json 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.9/metainfo.xml 
> PRE-CREATION 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/core-site.xml
>  9dcf561 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/hadoop-env.xml
>  8697740 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/hdfs-log4j.xml
>  215a6ee 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/hdfs-site.xml
>  ac141d1 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/ranger-hdfs-audit.xml
>  fd41817 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/ranger-hdfs-plugin-properties.xml
>  b31742c 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/ranger-hdfs-policymgr-ssl.xml
>  1bc83df 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/ranger-hdfs-security.xml
>  1b0a821 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/configuration/widgets.json
>  4a645b0 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/kerberos.json 
> 9000e95 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/metainfo.xml 
> 30c49c7 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/quicklinks/quicklinks.json
>  5318ba0 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/HDFS/themes/theme.json
>  6f2b797 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/YARN_widgets.json
>  782f21d 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration-mapred/mapred-env.xml
>  a70fad3 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration-mapred/mapred-site.xml
>  cef2b14 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration/capacity-scheduler.xml
>  4768e46 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration/ranger-yarn-audit.xml
>  a6b1baa 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration/ranger-yarn-plugin-properties.xml
>  97867cc 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration/ranger-yarn-policymgr-ssl.xml
>  5410104 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration/ranger-yarn-security.xml
>  5f69962 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration/yarn-env.xml
>  bbc2930 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration/yarn-log4j.xml
>  9ac34f3 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/configuration/yarn-site.xml
>  e33b91d 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/kerberos.json 
> e690204 
>   ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/metainfo.xml 
> 7e1fd78 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/quicklinks-mapred/quicklinks.json
>  5ffbc07 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/quicklinks/quicklinks.json
>  37248d0 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/themes-mapred/theme.json
>  5019447 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/YARN/themes/theme.json
>  758cf0c 
>   
> ambari-server/src/main/resources/stacks/HDP/3.0/services/ZOOKEEPER/metainfo.xml
>  5d4fb4d 
> 
> Diff: https://reviews.apache.org/r/54513/diff/
> 
> 
> Testing
> -------
> 
> Java unit test passed for ServicePropertiesTest.java
> 
> Python unit tests passed.
> 
> ----------------------------------------------------------------------
> Total run:1167
> Total errors:0
> Total failures:0
> OK
> 
> 
> Thanks,
> 
> Alejandro Fernandez
> 
>

Reply via email to