> On Dec. 9, 2016, 2:43 p.m., Sid Wagle wrote: > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java, > > line 315 > > <https://reviews.apache.org/r/54552/diff/1/?file=1579998#file1579998line315> > > > > Does order of items in source and data matter here ? Please ignore if > > this comment doesn't apply. But if source is unique but 2 data items have > > same value. ['a', 'b', 'c'] -> ['d', 'd', 'f']
Good question. The use-case I built this for is a list of hosts where order does not matter. However I can see where order might be a concern for some configurations, but I am not sure of a good way to handle that with a simple "append" function. I was going on the assumption that the feature would work a lot like `java.util.List#add(E)`. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54552/#review158711 ----------------------------------------------------------- On Dec. 8, 2016, 5:59 p.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54552/ > ----------------------------------------------------------- > > (Updated Dec. 8, 2016, 5:59 p.m.) > > > Review request for Ambari, Attila Magyar, Laszlo Puskas, Sumit Mohanty, and > Thejas Nair. > > > Bugs: AMBARI-19133 > https://issues.apache.org/jira/browse/AMBARI-19133 > > > Repository: ambari > > > Description > ------- > > `hadoop.proxyuser.HTTP.hosts` should not be updated when Hive is installed > unless WebHcat is installed. > > This is happening because the following block in the Kerberos descriptor is > at the HIVE service level rather than the WEBHCAT_SERVER component level. > > ``` > { > "core-site": { > "hadoop.proxyuser.HTTP.hosts": > "${clusterHostInfo/webhcat_server_host}" > } > }, > ``` > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelper.java > d472b79 > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/kerberos.json > 872bfac > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/kerberos.json > 34bda73 > > ambari-server/src/test/java/org/apache/ambari/server/state/kerberos/VariableReplacementHelperTest.java > 90f7022 > > Diff: https://reviews.apache.org/r/54552/diff/ > > > Testing > ------- > > Manually tested > > # Local test results: PENDING > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
