> On Dec. 11, 2016, 6:42 p.m., Oliver Szabo wrote: > > .reviewboardrc, line 22 > > <https://reviews.apache.org/r/54614/diff/1/?file=1581231#file1581231line22> > > > > how is that BRANCH value wokrs? is it an environement value which can > > be redefined externally? if that is used by default in the future (after > > 2.5 release) its needed to update the branch here. (from branch-2.5 to > > branch-xx etc.) > > > > maybe it would be better just include ".reviewboardrc" file into > > .gitignore file instead of adding ".reviewboardrc" (rbt command line tool > > install is not included in ambari project anyway, but with that you can > > keep your config file in your repo) > > Attila Doroszlai wrote: > All values from the config file can be overridden in the command-line, so > one can specify eg. --branch 'trunk' to submit a trunk-only patch. > Yes, the file will need to be updated in the future for new branches.
then my vote is only include the file in .gitignore instead of adding .reviewboardrc - Oliver ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54614/#review158801 ----------------------------------------------------------- On Dec. 11, 2016, 3:18 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54614/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2016, 3:18 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, Oliver Szabo, > Sandor Magyari, and Sebastian Toader. > > > Bugs: AMBARI-19160 > https://issues.apache.org/jira/browse/AMBARI-19160 > > > Repository: ambari > > > Description > ------- > > ReviewBoard has [command-line > tools](https://www.reviewboard.org/docs/rbtools/) for working with review > requests. The goal of this change is to add a small [config > file](https://www.reviewboard.org/docs/rbtools/0.7/rbt/configuration/repositories/#reviewboardrc) > to the Ambari project, so that `rbt` can talk to the right RB server > out-of-the box. > > > Diffs > ----- > > .reviewboardrc PRE-CREATION > > Diff: https://reviews.apache.org/r/54614/diff/ > > > Testing > ------- > > ``` > $ mvn -N -DskipTests test > ... > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 2602 licence. > > $ rbt post --bugs-closed AMBARI-19160 --testing-done-file > ~/Documents/AMBARI-19160-test.txt > Review request #54614 posted. > ``` > > Note: need to `rbt login` once before being able to post. > > > Thanks, > > Attila Doroszlai > >
