----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54612/#review158851 -----------------------------------------------------------
Ship it! Ship It! - Jonathan Hurley On Dec. 9, 2016, 5:31 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54612/ > ----------------------------------------------------------- > > (Updated Dec. 9, 2016, 5:31 p.m.) > > > Review request for Ambari, Jonathan Hurley, Laszlo Puskas, Nate Cole, and > Sebastian Toader. > > > Bugs: AMBARI-19158 > https://issues.apache.org/jira/browse/AMBARI-19158 > > > Repository: ambari > > > Description > ------- > > Move checkstyle config out of the `execution` definition. > > > Diffs > ----- > > ambari-project/pom.xml b00be381ebfee1cf93900ea7c25e03b76cb520c0 > > Diff: https://reviews.apache.org/r/54612/diff/ > > > Testing > ------- > > For bugfix: > > ``` > mvn -pl ambari-server checkstyle:check > > cd ambari-server > mvn checkstyle:check > ``` > > For regression: > > ``` > mvn -pl ambari-server -DskipTests test > ``` > > Note: one needs to perform `mvn -am -pl ambari-server -DskipTests install` > first (once), to put the required modules in the local Maven repo. > > > Thanks, > > Attila Doroszlai > >
