----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54674/#review158900 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java <https://reviews.apache.org/r/54674/#comment229720> Because this is changing data, should the data manipulation be wrapped in an `executeInTransaction(Runnable)` ? - Jonathan Hurley On Dec. 12, 2016, 3:01 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54674/ > ----------------------------------------------------------- > > (Updated Dec. 12, 2016, 3:01 p.m.) > > > Review request for Ambari, Jonathan Hurley, Sebastian Toader, and Sid Wagle. > > > Bugs: AMBARI-19170 > https://issues.apache.org/jira/browse/AMBARI-19170 > > > Repository: ambari > > > Description > ------- > > Removed @Transactional > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog240.java > 063c29539e135433b7b9ce37fa5c32d0de2234f8 > > Diff: https://reviews.apache.org/r/54674/diff/ > > > Testing > ------- > > Installed 2.2.2.0-460, upgraded to 2.5.0.0-453. > > ``` > [root@c6401 ~]# ambari-server upgrade > Using python /usr/bin/python > Upgrading ambari-server > INFO: Upgrade Ambari Server > INFO: Updating Ambari Server properties in ambari.properties ... > INFO: Updating Ambari Server properties in ambari-env.sh ... > WARNING: Original file ambari-env.sh kept > INFO: Fixing database objects owner > Ambari Server configured for Embedded Postgres. Confirm you have made a > backup of the Ambari Server database [y/n] (y)? y > INFO: Upgrading database schema > INFO: Return code from schema upgrade command, retcode = 0 > INFO: Schema upgrade completed > Adjusting ambari-server permissions and ownership... > Ambari Server 'upgrade' completed successfully. > ``` > > > Thanks, > > Attila Doroszlai > >
