-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54543/#review158988
-----------------------------------------------------------


Ship it!




Ship It!

- Andrew Onischuk


On Dec. 12, 2016, 7:58 p.m., Di Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54543/
> -----------------------------------------------------------
> 
> (Updated Dec. 12, 2016, 7:58 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk and Tim Thorpe.
> 
> 
> Bugs: AMBARI-19140
>     https://issues.apache.org/jira/browse/AMBARI-19140
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Notice the "//" in the symbolic link , where it could have been trimmed to be 
> just one leading "/"
> 
> [root]# ll /usr/sbin/ambari-server
> lrwxrwxrwx 1 root root 26 Dec 5 11:27 /usr/sbin/ambari-server -> 
> //etc/init.d/ambari-server
> [root]# clear
> [root]# ll
> total 20
> drwxrwxr-x 4 root root 8192 Dec 5 11:32 ambari_agent
> lrwxrwxrwx 1 root root 42 Dec 5 11:27 ambari_commons -> 
> //usr/lib/ambari-server/lib/ambari_commons
> lrwxrwxrwx 1 root root 41 Dec 5 11:27 ambari_jinja2 -> 
> //usr/lib/ambari-server/lib/ambari_jinja2
> drwxrwxr-x 2 root root 4096 Dec 5 11:28 ambari_server
> lrwxrwxrwx 1 root root 45 Dec 5 11:27 ambari_simplejson -> 
> //usr/lib/ambari-server/lib/ambari_simplejson
> lrwxrwxrwx 1 root root 47 Dec 5 11:27 resource_management -> 
> //usr/lib/ambari-server/lib/resource_management
> drwxr-xr-x 5 ams hadoop 83 Dec 6 09:26 resource_monitoring
> 
> 
> Diffs
> -----
> 
>   ambari-server/conf/unix/install-helper.sh 34ec0e9 
>   ambari-server/src/main/package/rpm/posttrans_server.sh a719cae 
>   ambari-server/src/main/package/rpm/preinstall.sh 524fea8 
> 
> Diff: https://reviews.apache.org/r/54543/diff/
> 
> 
> Testing
> -------
> 
> build Ambari RPMs, install a trunk cluster with my own RPMs, verify the 
> double "/"s are trimmed now.
> 
> 
> Thanks,
> 
> Di Li
> 
>

Reply via email to