> On Dec. 13, 2016, 6:46 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml, > > line 46 > > <https://reviews.apache.org/r/54690/diff/1/?file=1582375#file1582375line46> > > > > Should we mark this property as deleted in HDP 2.6?
Thought of that but I do not think it will help. Upon Ambari upgrade, the property will no longer be visible in the stack definition. Even if its in the DB, its ignored. Marking it as deleted does not auto-delete properties from the persisted configs. Usually deleted allows for a property to be valid in a stack version and invisible in the next version. We are going for a full delete from all versions here. - Sumit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54690/#review159037 ----------------------------------------------------------- On Dec. 13, 2016, 2:30 a.m., Sumit Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54690/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2016, 2:30 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Aravindan Vijayan, and Jaimin > Jetly. > > > Bugs: AMBARI-19184 > https://issues.apache.org/jira/browse/AMBARI-19184 > > > Repository: ambari > > > Description > ------- > > Remove HSI host name from UI > > > Diffs > ----- > > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/configuration/hive-interactive-env.xml > 7b20728 > > ambari-server/src/main/resources/stacks/HDP/2.5/services/HIVE/themes/theme.json > 1d50b6a > ambari-server/src/main/resources/stacks/HDP/2.5/services/stack_advisor.py > 60c1cac > ambari-server/src/test/python/stacks/2.5/common/test_stack_advisor.py > 54fe42a > ambari-server/src/test/python/stacks/2.5/configs/hsi_ha.json 7f95a35 > > Diff: https://reviews.apache.org/r/54690/diff/ > > > Testing > ------- > > Manually ran all tests and tested by manually deploying the cluster with > patches. > > > Thanks, > > Sumit Mohanty > >
