-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54787/
-----------------------------------------------------------
Review request for Ambari, Attila Magyar, Robert Levas, and Sebastian Toader.
Bugs: AMBARI-19132
https://issues.apache.org/jira/browse/AMBARI-19132
Repository: ambari
Description
-------
Added method `ShellCommandUtil.delete`
Note: couldn't try on Windows, command to delete taken from
https://www.sitepoint.com/web-foundations/force-windows-delete-file/
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/serveraction/kerberos/DestroyPrincipalsServerAction.java
8197e769f0538cb50b11284431decf9be3dc2370
ambari-server/src/main/java/org/apache/ambari/server/utils/ShellCommandUtil.java
57044d7b56895eb7cc1abd6284c747555ec550a1
ambari-server/src/test/java/org/apache/ambari/server/utils/TestShellCommandUtil.java
797ceb207b5fb0f8074429084f3fdcf1d7fefc6b
Diff: https://reviews.apache.org/r/54787/diff/
Testing
-------
Manually tested via "Disable Kerberos" wizard on non-root Ambari.
```
[root@c6401 ~]# grep server.user /etc/ambari-server/conf/ambari.properties
ambari-server.user=ambari
```
Before:
```
[root@c6401 ~]# ls -la /etc/security/keytabs/
total 20
drwxr-xr-x 2 root root 4096 Dec 15 13:26 .
drwxr-xr-x. 7 root root 4096 Dec 15 13:21 ..
-r--r----- 1 ambari-qa hadoop 338 Dec 15 13:26 smokeuser.headless.keytab
-r--r----- 1 root ambari 413 Dec 15 13:26 spnego.service.keytab
-r-------- 1 zookeeper hadoop 438 Dec 15 13:26 zk.service.keytab
```
After:
```
[root@c6401 ~]# ls -la /etc/security/keytabs/
total 8
drwxr-xr-x 2 root root 4096 Dec 15 15:58 .
drwxr-xr-x. 7 root root 4096 Dec 15 13:21 ..
```
Added unit test for new `delete` method:
```
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.152 sec - in
org.apache.ambari.server.utils.TestShellCommandUtil
```
Thanks,
Attila Doroszlai
