> On Dec. 20, 2016, 11:19 a.m., Attila Magyar wrote: > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java, > > line 538 > > <https://reviews.apache.org/r/54900/diff/1/?file=1589739#file1589739line538> > > > > Do we really need to specify how many times these getters will be > > invoked? Isn't it too strict? What will happen if the code changes and this > > breaks, will it indicate a bug or not (same question applies to most of the > > query methods)? Or can't we just use a real PermissionEntity in place of > > the mock?
I suppose the `times` stuff is overkill. But the difference bettween a mock and a `PermissionEntity` is negligible. I can change this if you think it is necessary. - Robert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54900/#review159723 ----------------------------------------------------------- On Dec. 20, 2016, 10:16 a.m., Robert Levas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54900/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 10:16 a.m.) > > > Review request for Ambari, Attila Magyar, Eugene Chekanskiy, Jonathan Hurley, > and Laszlo Puskas. > > > Bugs: AMBARI-19195 > https://issues.apache.org/jira/browse/AMBARI-19195 > > > Repository: ambari > > > Description > ------- > > Add permission to give a role the ability to set services to auto-start. This > permission should be allowed at the cluster-level to toggle the feature for > the cluster (Manage Service Auto Start Configuration) and at the > service-level to toggle the feature for specific services (Manage Service > Auto Start). However the service-level feature may not be available via all > interfaces. > > The following roles should be able to toggle auto-start at the cluster level: > - Ambari Administrator > - Cluster Administrator > - Cluster Operator > > The following roles should be able to toggle auto-start at the service level: > - Ambari Administrator > - Cluster Administrator > - Cluster Operator > - Service Administrator > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java > 5f64c18 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ComponentResourceProvider.java > 453c688 > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ConfigurationResourceProvider.java > 6e9765c > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/HostResourceProvider.java > 05d635a > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/AmbariAuthorizationFilter.java > c7362aa > > ambari-server/src/main/java/org/apache/ambari/server/security/authorization/RoleAuthorization.java > 4a0ea71 > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > a7e73fe > ambari-server/src/main/resources/Ambari-DDL-Derby-CREATE.sql 6d79cd4 > ambari-server/src/main/resources/Ambari-DDL-MySQL-CREATE.sql b493d0a > ambari-server/src/main/resources/Ambari-DDL-Oracle-CREATE.sql 3e40103 > ambari-server/src/main/resources/Ambari-DDL-Postgres-CREATE.sql e072805 > ambari-server/src/main/resources/Ambari-DDL-SQLAnywhere-CREATE.sql 01d9be5 > ambari-server/src/main/resources/Ambari-DDL-SQLServer-CREATE.sql dc03827 > > ambari-server/src/test/java/org/apache/ambari/server/security/TestAuthenticationFactory.java > a66a3c9 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 5e89039 > > Diff: https://reviews.apache.org/r/54900/diff/ > > > Testing > ------- > > Manually tested > > # Local test results: PASSED > > # Jenkins test results: PENDING > > > Thanks, > > Robert Levas > >
