-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54912/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Robert Levas.
Bugs: AMBARI-19259
https://issues.apache.org/jira/browse/AMBARI-19259
Repository: ambari
Description
-------
When editing an alert group which has targets via the UI, sometimes the
following is seen:
```
16 Nov 2016 11:09:49,343 WARN [qtp-ambari-client-510524] ServletHandler:563 -
/api/v1/clusters/EHIHADOOP03/alert_groups/155
java.util.ConcurrentModificationException
at java.util.HashMap$HashIterator.nextNode(HashMap.java:1429)
at java.util.HashMap$KeyIterator.next(HashMap.java:1453)
at
org.eclipse.persistence.indirection.IndirectSet$1.next(IndirectSet.java:471)
at
org.apache.ambari.server.orm.entities.AlertGroupEntity.setAlertTargets(AlertGroupEntity.java:313)
at
org.apache.ambari.server.controller.internal.AlertGroupResourceProvider.updateAlertGroups(AlertGroupResourceProvider.java:344)
at
org.apache.ambari.server.controller.internal.AlertGroupResourceProvider.access$100(AlertGroupResourceProvider.java:60)
at
org.apache.ambari.server.controller.internal.AlertGroupResourceProvider$2.invoke(AlertGroupResourceProvider.java:187)
at
org.apache.ambari.server.controller.internal.AlertGroupResourceProvider$2.invoke(AlertGroupResourceProvider.java:184)
at
org.apache.ambari.server.controller.internal.AbstractResourceProvider.invokeWithRetry(AbstractResourceProvider.java:450)
at
org.apache.ambari.server.controller.internal.AbstractResourceProvider.modifyResources(AbstractResourceProvider.java:331)
```
The in-memory collection is not thread safe.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertGroupEntity.java
76c6b62
ambari-server/src/main/java/org/apache/ambari/server/orm/entities/AlertTargetEntity.java
9668210
ambari-server/src/test/java/org/apache/ambari/server/orm/dao/AlertDispatchDAOTest.java
87afb38
Diff: https://reviews.apache.org/r/54912/diff/
Testing
-------
PENDING
Thanks,
Jonathan Hurley
