> On Dec. 21, 2016, 4:45 p.m., Sebastian Toader wrote: > > ambari-agent/src/main/python/ambari_agent/FileCache.py, line 161 > > <https://reviews.apache.org/r/54939/diff/1/?file=1590342#file1590342line161> > > > > This one is redundant know.
There are a few things that can go wrong between the two lines (eg. failure to download, empty archive, failure to unpack), so I don't think the "Updating" log is redundant. > On Dec. 21, 2016, 4:45 p.m., Sebastian Toader wrote: > > ambari-agent/src/main/python/ambari_agent/FileCache.py, line 170 > > <https://reviews.apache.org/r/54939/diff/1/?file=1590342#file1590342line170> > > > > Can you estimate how much log it may create the worst case scenario > > just to be sure that we don't flood the agent log. Candidates are services (~33), hooks (5), custom resources subdirectories (?), custom actions (1) and host scripts (1). Each directory is checked only once per agent registration even if the source is changed on the server. Unnecessary updates (and thus log messages) of directories not changed on the server are prevented across registrations by the persistent hash. - Attila ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54939/#review159818 ----------------------------------------------------------- On Dec. 21, 2016, 4:42 p.m., Attila Doroszlai wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54939/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 4:42 p.m.) > > > Review request for Ambari, Balázs Bence Sári, Laszlo Puskas, and Sebastian > Toader. > > > Bugs: AMBARI-19270 > https://issues.apache.org/jira/browse/AMBARI-19270 > > > Repository: ambari > > > Description > ------- > > Sample output: > > ``` > INFO 2016-12-21 14:52:44,542 FileCache.py:170 - Updated directory > /var/lib/ambari-agent/cache/host_scripts > INFO 2016-12-21 14:52:44,921 FileCache.py:170 - Updated directory > /var/lib/ambari-agent/cache/stacks/HDP/2.0.6/hooks > INFO 2016-12-21 14:52:44,944 FileCache.py:170 - Updated directory > /var/lib/ambari-agent/cache/common-services/YARN/3.0.0/package > INFO 2016-12-21 14:55:23,562 FileCache.py:170 - Updated directory > /var/lib/ambari-agent/cache/common-services/HDFS/2.1.0.2.0/package > INFO 2016-12-21 14:55:35,236 FileCache.py:170 - Updated directory > /var/lib/ambari-agent/cache/common-services/TEZ/0.4.0.2.1/package > INFO 2016-12-21 14:55:59,220 FileCache.py:170 - Updated directory > /var/lib/ambari-agent/cache/common-services/ZOOKEEPER/3.4.5/package > INFO 2016-12-21 15:10:04,535 FileCache.py:170 - Updated directory > /var/lib/ambari-agent/cache/common-services/SQOOP/1.4.4.2.0/package > ``` > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/FileCache.py > a9ea8f6de1c30ee59002a3a22a044797b66abb17 > > Diff: https://reviews.apache.org/r/54939/diff/ > > > Testing > ------- > > Tested manually: create cluster; add service. > > Unit tests: > > ``` > $ mvn -am -pl ambari-agent clean test > ... > Ran 451 tests in 15.364s > > OK > ... > [INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 > approved: 151 licence. > ... > [INFO] Ambari Agent ...................................... SUCCESS [20.857s] > ``` > > > Thanks, > > Attila Doroszlai > >
