-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54935/#review159837
-----------------------------------------------------------


Ship it!





ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 (line 150)
<https://reviews.apache.org/r/54935/#comment230870>

    suggest rename to HadoopEnvConfigs.


- Sid Wagle


On Dec. 21, 2016, 4:55 p.m., Dmytro Sen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54935/
> -----------------------------------------------------------
> 
> (Updated Dec. 21, 2016, 4:55 p.m.)
> 
> 
> Review request for Ambari, Sumit Mohanty, Sid Wagle, and Vitalyi Brodetskyi.
> 
> 
> Bugs: AMBARI-19268
>     https://issues.apache.org/jira/browse/AMBARI-19268
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> After upgrade from 2.0.0 hadoop-env doesn't contain:
> 
> {% if is_datanode_max_locked_memory_set %}
> # Fix temporary bug, when ulimit from conf files is not picked up, without 
> full relogin. 
> # Makes sense to fix only when runing DN as root 
> if [ "$command" == "datanode" ] &amp;&amp; [ "$EUID" -eq 0 ] &amp;&amp; [ -n 
> "$HADOOP_SECURE_DN_USER" ]; then
>   ulimit -l {{datanode_max_locked_memory}}
> fi
> {% endif %}
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
>  7a385f3 
>   
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
>  8568a19 
> 
> Diff: https://reviews.apache.org/r/54935/diff/
> 
> 
> Testing
> -------
> 
> Unit test passed
> 
> 
> Thanks,
> 
> Dmytro Sen
> 
>

Reply via email to