----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54922/#review159847 -----------------------------------------------------------
Ship it! Ship It! - Vivek Ratnavel Subramanian On Dec. 21, 2016, 12:05 a.m., Xi Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54922/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 12:05 a.m.) > > > Review request for Ambari, Jaimin Jetly, Vivek Ratnavel Subramanian, and > Yusaku Sako. > > > Bugs: AMBARI-19260 > https://issues.apache.org/jira/browse/AMBARI-19260 > > > Repository: ambari > > > Description > ------- > > After Implemented the new design guidelines, there are several issues to fix > on Dashboard page: > 1. Service menu > Actions dropdown should be left aligned. see attached. > 2. Widget > MORE button was too large, should be the same font size as the > text with less padding. see attached. > 3. Hovering on each widget, the remove icon showed up, but the title shifted > to the right. The title show be still when hovering. > 4. YARN links and HDFS links have different "MORE button" colors. should be > the same white. > 5. Metric Actions > Add, remove the cancel button (cancel did nothing), > change text 'Apply' to 'Add', then right align the 'add' button. see > attached. > > > Diffs > ----- > > ambari-web/app/styles/application.less 4a50af7 > ambari-web/app/styles/dashboard.less 9e1213e > ambari-web/app/templates/main/dashboard/plus_button_filter.hbs 81420ff > ambari-web/app/templates/main/service/all_services_actions.hbs f2ce0fd > ambari-web/app/views/main/dashboard/widgets.js 4e22aad > > Diff: https://reviews.apache.org/r/54922/diff/ > > > Testing > ------- > > 19713 passing (18s) > 153 pending > > > Thanks, > > Xi Wang > >
