> On Dec. 22, 2016, 1:17 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py, > > line 228 > > <https://reviews.apache.org/r/54955/diff/1/?file=1590655#file1590655line228> > > > > These should be in > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/package/scripts/params_linux.py. > > Basically, its service specific changes and should really be needed by the > > service specific scripts that generate the file. > > > > Similarly hbase and ams_hbase should also be moved to hbase and > > ams_hbase specific params python files.
Referring to the old hdfs patch, the changes were added to the common params.py I can move each of these to their specific services params_linux.py I will modify it for yarn,hdfs,hbase,zookeeper,ams. > On Dec. 22, 2016, 1:17 a.m., Sumit Mohanty wrote: > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py, > > line 244 > > <https://reviews.apache.org/r/54955/diff/1/?file=1590655#file1590655line244> > > > > Its not clear why we should append all log4j contents into one file? The yarn and hdfs were being added to /etc/hadoop/conf/log4j.properties, I followed the same path. Considering we have one such file for each service within /etc/, I can put it in those instead. - Madhuvanthi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54955/#review159901 ----------------------------------------------------------- On Dec. 21, 2016, 10:59 p.m., Madhuvanthi Radhakrishnan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54955/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2016, 10:59 p.m.) > > > Review request for Ambari and Sumit Mohanty. > > > Bugs: AMBARI-19274 > https://issues.apache.org/jira/browse/AMBARI-19274 > > > Repository: ambari > > > Description > ------- > > Add common log4j settings to advanced config - hbase, zookeeper, ams > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-hbase-log4j.xml > 08c7b94 > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/configuration/ams-log4j.xml > 81f6dbc > > ambari-server/src/main/resources/common-services/HBASE/0.96.0.2.0/configuration/hbase-log4j.xml > 8495de1 > > ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/configuration/yarn-log4j.xml > 89dd52d > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.5/configuration/zookeeper-log4j.xml > 04f872c > > ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/scripts/params.py > fe71a43 > > ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/configuration/yarn-log4j.xml > 84c6db1 > > Diff: https://reviews.apache.org/r/54955/diff/ > > > Testing > ------- > > 1. Ensure that log4j rolling parameters appear in UI as separate properties > 2. Change value and check if reflected in Database, API and file > > > Thanks, > > Madhuvanthi Radhakrishnan > >
