-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54936/#review160086
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Levas


On Dec. 22, 2016, 3:53 p.m., Attila Magyar wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54936/
> -----------------------------------------------------------
> 
> (Updated Dec. 22, 2016, 3:53 p.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Balázs Bence Sári, Eugene 
> Chekanskiy, Laszlo Puskas, Robert Levas, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19269
>     https://issues.apache.org/jira/browse/AMBARI-19269
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> I modified the kerberization/dekerberization process of YARN RM
> based on 
> https://docs.google.com/document/d/1IEAVBFU2QMhKP5It4_u7L1UtP_QRBTHUk9cOuHjK8AU/
> 
> - yarn.resourcemanager.zk-acl is set to sasl:rm:rwcda when kerberos is 
> enabled (kerberos.json) 
> - jaas file is added to YARN_OPTS with the correct principal and keytab when 
> kerberos is enabled
> - ACL is reverted to world:anyone:crdwa when disabling kerberos
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/kerberos.json 
> 4093431 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/params_linux.py
>  0496995 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/resourcemanager.py
>  6a7eea7 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/scripts/yarn.py
>  f5acb11 
>   
> ambari-server/src/main/resources/common-services/YARN/2.1.0.2.0/package/templates/yarn_jaas.conf.j2
>  PRE-CREATION 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/kerberos.json 
> e690204 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/params_linux.py
>  cdadc80 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/resourcemanager.py
>  e053fe6 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/scripts/yarn.py
>  70ed5b3 
>   
> ambari-server/src/main/resources/common-services/YARN/3.0.0.3.0/package/templates/yarn_jaas.conf.j2
>  PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.2/services/YARN/kerberos.json 
> 2fdce8a 
>   
> ambari-server/src/main/resources/stacks/HDP/2.3.ECS/services/YARN/kerberos.json
>  b02b3e9 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/YARN/kerberos.json 
> 0d67e59 
>   ambari-server/src/main/resources/stacks/HDP/2.5/services/YARN/kerberos.json 
> e690204 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_historyserver.py 
> bea3f81 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_mapreduce2_client.py 
> 466b0f7 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_nodemanager.py 4abf2c9 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_resourcemanager.py 
> 7b5ce18 
>   ambari-server/src/test/python/stacks/2.0.6/YARN/test_yarn_client.py 3719fe5 
> 
> Diff: https://reviews.apache.org/r/54936/diff/
> 
> 
> Testing
> -------
> 
> Manual testing:
>  - created a cluster with YARN + HDFS + ZooKeeper
>  - enabled kerberos
>  - check that the acl on /rmstore/ZKRMStateRoot is set to sasl
>  - disabled kerberos
>  - checked that the acl on /rmstore/ZKRMStateRoot is 'world,'anyone
>  - Enabled YARN RM HA mode, repeated the above test
> 
> Tests:
> Ambari server:
> Tests run: 4782, Failures: 0, Errors: 0, Skipped: 37
> 
> Python tests:
> Total run:1146
> Total errors:0
> Total failures:0
> 
> Ambari agent:
> Ran 447 tests in 22.056s
> 
> 
> Thanks,
> 
> Attila Magyar
> 
>

Reply via email to