----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54887/#review160234 -----------------------------------------------------------
Ship it! Ship It! - Yusaku Sako On Dec. 20, 2016, 11:24 a.m., Vivek Ratnavel Subramanian wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54887/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2016, 11:24 a.m.) > > > Review request for Ambari, Jaimin Jetly, Richard Zang, Xi Wang, and Yusaku > Sako. > > > Bugs: AMBARI-19252 > https://issues.apache.org/jira/browse/AMBARI-19252 > > > Repository: ambari > > > Description > ------- > > Incorrect Method types displayed in the description of created Alert > notification. > > STR: > 1. Create Alert Notifications with Methods "Custom SNMP" and "SNMP" > 2. After creation, select the created "Custom SNMP" notification the method > type is displayed as "SNMP" in the UI > 3. Select the created "SNMP" notification the method type is displayed as > "AMBARI_SNMP" in the UI > > > Diffs > ----- > > > ambari-web/app/controllers/main/alerts/manage_alert_notifications_controller.js > 466d2e1 > ambari-web/app/templates/main/alerts/manage_alert_notifications_popup.hbs > 5599e09 > ambari-web/app/views/main/alerts/manage_alert_notifications_view.js 9d01791 > > ambari-web/test/controllers/main/alerts/manage_alert_notifications_controller_test.js > a0a4ce4 > > Diff: https://reviews.apache.org/r/54887/diff/ > > > Testing > ------- > > Verified Manually. > Ambari-web unit tests pass. > 19726 passing (14s) > 153 pending > > > Thanks, > > Vivek Ratnavel Subramanian > >
