----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55081/ -----------------------------------------------------------
Review request for Ambari and Andrii Tkach. Bugs: AMBARI-19287 https://issues.apache.org/jira/browse/AMBARI-19287 Repository: ambari Description ------- *STR:* # Add a custom property by keeping trailing whitespace in the property name *Expected behavior:* white spaces at the end and similar white space in the beginning of the property name should be trimmed and the property should be added and shown in the custom section *Actual behavior:* Validation error is shown users that copy paste property name from some document to the custom property addition dialog often have trailing white spaces and see a validation error that leads to confusion. Note: Scope of this work is for both single property addition and bulk addition of all properties but it is limited to only property name. No logic related to property value needs to be changed as part of this task Diffs ----- ambari-web/app/utils/validator.js c7248bb ambari-web/app/views/common/configs/service_configs_by_category_view.js 3ebc2cf ambari-web/test/controllers/main/host/details_test.js 859320e ambari-web/test/utils/validator_test.js 4f069e0 Diff: https://reviews.apache.org/r/55081/diff/ Testing ------- 19991 tests complete (25 seconds) 153 tests pending Thanks, Oleg Nechiporenko