----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55168/#review160487 -----------------------------------------------------------
ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java (line 120) <https://reviews.apache.org/r/55168/#comment231637> We could lose precision here - I think this should remain as either a string or be used as a different data type. - Jonathan Hurley On Jan. 4, 2017, 6:18 a.m., Dmytro Sen wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55168/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2017, 6:18 a.m.) > > > Review request for Ambari, Jonathan Hurley and Vitalyi Brodetskyi. > > > Bugs: AMBARI-19356 > https://issues.apache.org/jira/browse/AMBARI-19356 > > > Repository: ambari > > > Description > ------- > > SNMPv2-SMI::enterprises.18060.16.1.1.1.1 = STRING: "6" - This needs to be > sent as an INTEGER > SNMPv2-SMI::enterprises.18060.16.1.1.1.6 = STRING: "3" - This needs to be > sent as an INTEGER > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcher.java > 86ef07c > > ambari-server/src/test/java/org/apache/ambari/server/notifications/dispatchers/AmbariSNMPDispatcherTest.java > 3561730 > > Diff: https://reviews.apache.org/r/55168/diff/ > > > Testing > ------- > > Unit tests passed > > > Thanks, > > Dmytro Sen > >
