----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55176/#review160499 -----------------------------------------------------------
Fix it, then Ship it! Looks fine, other than the minor issue below. ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml (line 180) <https://reviews.apache.org/r/55176/#comment231639> Minor spelling issue: "separeted" should be "separated" - Robert Nettleton On Jan. 4, 2017, 2:19 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55176/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2017, 2:19 p.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-19363 > https://issues.apache.org/jira/browse/AMBARI-19363 > > > Repository: ambari > > > Description > ------- > > Comma separated roles are hard coded in logsearch ambari integration code. If > a user changes their privilege, the user wont know why he cant login into > logsearch. > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-properties.xml > 8fc71d5 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 811b3ea > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > 00dd641 > ambari-server/src/test/python/stacks/2.4/configs/default.json a601f0b > ambari-web/app/data/HDP2/site_properties.js e2a4d4e > > Diff: https://reviews.apache.org/r/55176/diff/ > > > Testing > ------- > > testing done. > > > Thanks, > > Oliver Szabo > >
