-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55188/
-----------------------------------------------------------

Review request for Ambari, Dmytro Sen, Sandor Magyari, Sumit Mohanty, and 
Sebastian Toader.


Bugs: AMBARI-19372
    https://issues.apache.org/jira/browse/AMBARI-19372


Repository: ambari


Description
-------

Added check for `parallel_execution` flag.


Diffs
-----

  ambari-agent/src/main/python/ambari_agent/FileCache.py 
d0c8bdbcb69db1216a8dde47700535f5a36b36e4 
  ambari-agent/src/test/python/ambari_agent/TestFileCache.py 
00f6b6971b1af32fc99a4c28e69a32a2d130e5de 

Diff: https://reviews.apache.org/r/55188/diff/


Testing
-------

Manual test:

 * set `syslog_enabled = 1`, `loglevel = DEBUG` in `ambari-agent.ini`
 * submit blueprint cluster creation
 * verify that FileCache update works as expected by default
 * set `parallel_execution = 1` in `ambari-agent.ini`
 * submit blueprint cluster creation
 * verify that both `ambari-agent` processes refuse to update the cache

```
$ pstree -ap
...
  `python,15266 /usr/lib/python2.6/site-packages/ambari_agent/AmbariAgent.py 
start
  |   `python,15274 /usr/lib/python2.6/site-packages/ambari_agent/main.py start
  |       `python,15292 /usr/lib/python2.6/site-packages/ambari_agent/main.py 
start
...

$ grep FileCache /var/log/messages
Jan  4 21:41:29 c6401  ambari_agent - FileCache.py - [15274] - root - DEBUG - 
Auto cache update is disabled.
...
Jan  4 21:42:47 c6401  ambari_agent - FileCache.py - [15292] - root - DEBUG - 
Auto cache update is disabled.
```

Added unit test.

```
$ mvn -pl ambari-agent -DskipSurefireTests clean test
...
Ran 455 tests in 15.162s

OK
...
[INFO] Rat check: Summary of files. Unapproved: 0 unknown: 0 generated: 0 
approved: 155 licence.
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
```


Thanks,

Attila Doroszlai

Reply via email to