-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55107/
-----------------------------------------------------------

(Updated Jan. 5, 2017, 3:02 a.m.)


Review request for Ambari, Oliver Szabo and Robert Nettleton.


Changes
-------

Added some unit tests + formatted some properties related codes + added missing 
site_properties elements


Bugs: AMBARI-19330
    https://issues.apache.org/jira/browse/AMBARI-19330


Repository: ambari


Description (updated)
-------

Upgrade the logsearch properties from 2.4 to 2.5

Also fixed some property descriptions / display names / xml formatting issues

Also added some missing site_properties elements


Diffs (updated)
-----

  
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java
 38c7537 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-ambari-config.xml
 64d7946 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-custom-logsearch-conf.xml
 8358266 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml
 bc65e3c 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-log4j.xml
 9371530 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-output-config.xml
 85654c8 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-properties.xml
 e7cd476 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-system_log-env.xml
 b8dd4b9 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-audit_logs-solrconfig.xml
 6272dd1 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-log4j.xml
 66b9bba 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-log4j.xml.j2
 cc5addf 
  
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java
 370588a 
  ambari-web/app/data/HDP2/site_properties.js e2a4d4e 

Diff: https://reviews.apache.org/r/55107/diff/


Testing
-------

Check configuration differences between logsearch in ambari version 2.4 and 2.5.
Manually did a yum upgrade with new packages, then during ambari upgrade:
- checked the new configurations were added properly
- implemented renames/deletions in UpgradeCatalog250.java


Thanks,

Miklos Gergely

Reply via email to