-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55244/
-----------------------------------------------------------

Review request for Ambari.


Bugs: AMBARI-19395
    https://issues.apache.org/jira/browse/AMBARI-19395


Repository: ambari


Description
-------

Unit tests on Apache are failing because the checkstyle rules are too strict, 
especially when it comes to imports.

Right now, it requires this, which I want to remove because it means that 
everyone has to use an IDE and setup the same rules for something that is 
trivial at compile-time and actually causes more headaches for developers.

```
    <module name="ImportOrder">
      <property name="groups" value="java,javax,org,com,*"/>
      <property name="ordered" value="true"/>
      <property name="separated" value="true"/>
      <property name="option" value="top"/> <!-- static imports -->
      <property name="sortStaticImportsAlphabetically" value="true"/>
    </module>
```


Diffs
-----

  ambari-admin/pom.xml 4a8bba3 
  ambari-server/checkstyle.xml bf7698d 
  ambari-views/pom.xml 4121fb5 
  utility/pom.xml 6f60206 

Diff: https://reviews.apache.org/r/55244/diff/


Testing
-------

mvn checkstyle:checkstyle


Thanks,

Alejandro Fernandez

Reply via email to