----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55262/#review160705 -----------------------------------------------------------
Ship it! Ship It! - Andrii Tkach On Jan. 6, 2017, 11:58 a.m., Oleg Nechiporenko wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55262/ > ----------------------------------------------------------- > > (Updated Jan. 6, 2017, 11:58 a.m.) > > > Review request for Ambari and Andrii Tkach. > > > Bugs: AMBARI-19401 > https://issues.apache.org/jira/browse/AMBARI-19401 > > > Repository: ambari > > > Description > ------- > > A computed property that returns value for trueKey property if dependent > value is true and falseKey-value otherwise > > {code:javascript} > var o = Em.Object.create({ > p1: true, > p2: 1, > p3: 2, > p4: Em.computed.ifThenElseByKeys('p1', 'p2', 'p3') > }); > console.log(o.get('p4')); // 1 > o.set('p1', false); > console.log(o.get('p4')); // 2 > > o.set('p3', 3); > console.log(o.get('p4')); // 3 > {code} > > > Diffs > ----- > > ambari-web/app/models/configs/objects/service_config_property.js 4459946 > ambari-web/app/models/configs/theme/tab.js ad3e6e4 > ambari-web/app/utils/ember_computed.js 08be4e5 > ambari-web/test/aliases/computed/filterBy.js 154c372 > ambari-web/test/aliases/computed/ifThenElseByKeys.js PRE-CREATION > ambari-web/test/init_computed_aliases.js 81ae5fa > ambari-web/test/models/configs/objects/service_config_property_test.js > 728141b > ambari-web/test/models/configs/theme/sub_section_test.js e89bce9 > ambari-web/test/models/configs/theme/tab_test.js 3a5f21d > ambari-web/test/utils/ember_computed_test.js 829f2e2 > > Diff: https://reviews.apache.org/r/55262/diff/ > > > Testing > ------- > > 20309 tests complete (24 seconds) > 153 tests pending > > > Thanks, > > Oleg Nechiporenko > >
