-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55250/#review160883
-----------------------------------------------------------


Ship it!




Ship It!

- Sebastian Toader


On Jan. 9, 2017, 11:53 a.m., Attila Doroszlai wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55250/
> -----------------------------------------------------------
> 
> (Updated Jan. 9, 2017, 11:53 a.m.)
> 
> 
> Review request for Ambari, Jonathan Hurley and Sebastian Toader.
> 
> 
> Bugs: AMBARI-19384
>     https://issues.apache.org/jira/browse/AMBARI-19384
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Replaced `$s` with `%s`
> 
> 
> Diffs
> -----
> 
>   
> ambari-server/src/main/java/org/apache/ambari/server/controller/metrics/RestMetricsPropertyProvider.java
>  0b8dd62d067ee61f78d5cdf16babf9f8f3c8842b 
> 
> Diff: https://reviews.apache.org/r/55250/diff/
> 
> 
> Testing
> -------
> 
> Manual test:
>  * create cluster with STORM and Ambari Metrics
>  * add widget for metric: Storm > Active Storm UI Server > 
> `/api/v1/cluster/summary##nimbusUptime`
>  * observe exception in `ambari-server.log`
> 
> ```
> org.apache.ambari.server.AmbariException: Unable to get REST metrics from the 
> for STORM_UI_SERVER at 
> http://c6401.ambari.apache.org:8744/api/v1/cluster/summary
> ```
> 
> 
> Thanks,
> 
> Attila Doroszlai
> 
>

Reply via email to