----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55249/#review160898 -----------------------------------------------------------
Ship it! ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeUtil.java (line 43) <https://reviews.apache.org/r/55249/#comment232141> Minor problem: "some.varibale" should be spelled "some.variable" I'm not opening on issue on this, since this could be fixed in a subsequent patch. - Robert Nettleton On Jan. 7, 2017, 1:47 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55249/ > ----------------------------------------------------------- > > (Updated Jan. 7, 2017, 1:47 a.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-19397 > https://issues.apache.org/jira/browse/AMBARI-19397 > > > Repository: ambari > > > Description > ------- > > Upgrade Infra solr related properties for ambari 2.5.0. > > > Diffs > ----- > > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/SchemaUpgradeUtil.java > PRE-CREATION > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > 3701e2f > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-client-log4j.xml > 87468a2 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/configuration/infra-solr-log4j.xml > b22dbf2 > > ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/properties/solr-log4j.properties.j2 > 275203a > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > c89522f > ambari-web/app/data/HDP2/site_properties.js 6c2d5e1 > > Diff: https://reviews.apache.org/r/55249/diff/ > > > Testing > ------- > > Checked configuration differences between ambari infra in ambari version 2.4 > and 2.5. > Manually did a yum upgrade: > - implemented propertiy changes in UpgradeCatalog250.java > - checked the new configurations were added properly > > > Thanks, > > Miklos Gergely > >
