----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55369/#review161098 -----------------------------------------------------------
Fix it, then Ship it! ambari-agent/src/main/python/ambari_agent/Facter.py (line 400) <https://reviews.apache.org/r/55369/#comment232333> Add documentation to these 2 functions ambari-agent/src/main/python/ambari_agent/Facter.py (line 505) <https://reviews.apache.org/r/55369/#comment232332> Add a comment as to why this was needed - Alejandro Fernandez On Jan. 10, 2017, 5:23 a.m., Masahiro Tanaka wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55369/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 5:23 a.m.) > > > Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Oliver > Szabo, Sebastian Toader, and Yusaku Sako. > > > Bugs: AMBARI-19415 > https://issues.apache.org/jira/browse/AMBARI-19415 > > > Repository: ambari > > > Description > ------- > > Ambari Agent Hardware check assumes there is `ifconfig` command in Linux, but > some environments (e.g. CentOS 7.3 with minimal install) doens't have > `ifconfig` command, but `ip` command. > > A warning like below (which is in ambari-agent.log) is because of the > assumption. > ``` > WARNING 2017-01-08 14:53:48,021 Facter.py:487 - Can't get a network > interfaces list from > ``` > > It would be better to check the NIC with `ifconfig` and `ip` both for better > coverage. > > > Diffs > ----- > > ambari-agent/src/main/python/ambari_agent/Facter.py 3643ff7 > ambari-agent/src/test/python/ambari_agent/TestHardware.py ff3b40b > > Diff: https://reviews.apache.org/r/55369/diff/ > > > Testing > ------- > > Hadoop QA added a comment - 13 hours ago > > +1 overall. Here are the results of testing the latest attachment > http://issues.apache.org/jira/secure/attachment/12846316/AMBARI-19415.0.patch > against trunk revision . > > +1 @author. The patch does not contain any @author tags. > > +1 tests included. The patch appears to include 1 new or modified test files. > > +1 javac. The applied patch does not increase the total number of javac > compiler warnings. > > +1 release audit. The applied patch does not increase the total number of > release audit warnings. > > +1 core tests. The patch passed unit tests in ambari-agent. > > Test results: > https://builds.apache.org/job/Ambari-trunk-test-patch/9963//testReport/ > Console output: > https://builds.apache.org/job/Ambari-trunk-test-patch/9963//console > > This message is automatically generated. > > > Thanks, > > Masahiro Tanaka > >
