----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55387/#review161099 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py (line 246) <https://reviews.apache.org/r/55387/#comment232336> -1. If the config doesn't exist at all, that's a problem and we shouldn't be brushing it under the rug. Why would sqoop be missing sqoop-site or knox be missing knoxsso-topology? I want to understand the root cause first. - Alejandro Fernandez On Jan. 10, 2017, 7 p.m., Di Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55387/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2017, 7 p.m.) > > > Review request for Ambari, Alejandro Fernandez and Tim Thorpe. > > > Bugs: AMBARI-19446 > https://issues.apache.org/jira/browse/AMBARI-19446 > > > Repository: ambari > > > Description > ------- > > Able to skip writing configuration files when the config type doesn't exist > in the command JSON file. > > > Diffs > ----- > > > ambari-common/src/main/python/resource_management/libraries/functions/get_config.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive.py > ea21c49 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/knox.py > cce9c5f > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_linux.py > 8416e98 > > ambari-server/src/main/resources/common-services/KNOX/0.5.0.2.2/package/scripts/params_windows.py > 53a3316 > > ambari-server/src/main/resources/common-services/SQOOP/1.4.4.2.0/package/scripts/sqoop.py > d005cbe > > Diff: https://reviews.apache.org/r/55387/diff/ > > > Testing > ------- > > existing unit test > build Ambari RPMS off trunk code and install a cluster. > > > Thanks, > > Di Li > >
