-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55016/
-----------------------------------------------------------
(Updated Jan. 11, 2017, 11:40 a.m.)
Review request for Ambari, Andrew Onischuk, Jonathan Hurley, Laszlo Puskas,
Sandor Magyari, and Sebastian Toader.
Changes
-------
* Use exclusive lock for `configure`, too, to avoid concurrent config file
creation
* Implement with metaclass instead of having to add to all subclasses
Bugs: AMBARI-19293
https://issues.apache.org/jira/browse/AMBARI-19293
Repository: ambari
Description
-------
* Perform `configure` called from `install` with shared lock
* Use exclusive lock in after-install hook
Diffs (updated)
-----
ambari-common/src/main/python/resource_management/libraries/script/script.py
ccb09c75a2a6e15c9f639c5eea4a9a60e8706942
ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/after-INSTALL/scripts/params.py
ed34217757540278a8730d58797cc47536e58874
Diff: https://reviews.apache.org/r/55016/diff/
Testing (updated)
-------
Manual test:
* install cluster via blueprint with parallel execution disabled (this is the
default)
* install cluster via blueprint with parallel execution enabled (needs packages
pre-installed and users pre-created)
Unit tests:
```
$ mvn -am -pl ambari-agent,ambari-server -DskipSurefireTests clean test
...
[INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-server ---
...
Total run:1158
Total errors:0
Total failures:0
OK
...
[INFO] --- exec-maven-plugin:1.2.1:exec (python-test) @ ambari-agent ---
...
Ran 452 tests in 22.538s
OK
...
[INFO] BUILD SUCCESS
```
(note: ambari-server test-compile may run into error, see AMBARI-19458)
Thanks,
Attila Doroszlai
