-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55342/
-----------------------------------------------------------
(Updated Jan. 11, 2017, 5:27 p.m.)
Review request for Ambari, Attila Doroszlai, Laszlo Puskas, Oliver Szabo,
Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
Changes
-------
Fixed review comments.
Bugs: AMBARI-19426
https://issues.apache.org/jira/browse/AMBARI-19426
Repository: ambari
Description
-------
Existing quicklinks API (e.g:
http://c6401:8080/api/v1/stacks/HDP/versions/2.5/services/ACCUMULO/quicklinks/quicklinks.json)
should return visible = true/false based on the quick links profile.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementController.java
cc20324
ambari-server/src/main/java/org/apache/ambari/server/controller/AmbariManagementControllerImpl.java
0affa4f
ambari-server/src/main/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProvider.java
5603765
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinks/Link.java
f589f5d
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinkVisibilityController.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinkVisibilityControllerFactory.java
PRE-CREATION
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfile.java
e86af38
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluator.java
31335b6
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorException.java
c24281a
ambari-server/src/main/java/org/apache/ambari/server/state/quicklinksprofile/ShowAllLinksVisibilityController.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/controller/internal/QuickLinkArtifactResourceProviderTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/EvaluatorTest.java
f54842d
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinkVisibilityControllerFactoryTest.java
PRE-CREATION
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileEvaluatorTest.java
6a31ca0
ambari-server/src/test/java/org/apache/ambari/server/state/quicklinksprofile/QuickLinksProfileParserTest.java
6f5dd07
ambari-server/src/test/resources/example_quicklinks_profile.json 2fa33a4
ambari-server/src/test/resources/inconsistent_quicklinks_profile_2.json
PRE-CREATION
Diff: https://reviews.apache.org/r/55342/diff/
Testing
-------
1. Did manual testing
2. Wrote new unit tests
3. Run the ambari-server unit test suite. Only KerberosServiceMetaInfoTest
failed, but it succeeded in a subsequent run.
Thanks,
Balázs Bence Sári
