----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55429/#review161288 -----------------------------------------------------------
Fix it, then Ship it! Patch looks fine to me, other than the minor issue that I've mentioned below. Thanks. ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ACLHandler.java (line 80) <https://reviews.apache.org/r/55429/#comment232520> Minor issue: Perhaps this method should return "true" upon the first difference encountered? It appears as if the full set of collection items is checked, even if an item early in the collection differs. Is this intended? - Robert Nettleton On Jan. 11, 2017, 4:16 p.m., Oliver Szabo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55429/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2017, 4:16 p.m.) > > > Review request for Ambari, Miklos Gergely and Robert Nettleton. > > > Bugs: AMBARI-19468 > https://issues.apache.org/jira/browse/AMBARI-19468 > > > Repository: ambari > > > Description > ------- > > - added setAcl operation inside logsearch code > - added reload collection command (on schema or solrconfig change) > - removed logsearch solr client dependency > - refactor some methods to handlers in collection dao > - removed upload configurations call from ambari logsearch stack code. > > using acls still not in use, that will go in with a different patch > > > Diffs > ----- > > ambari-logsearch/ambari-logsearch-portal/pom.xml 9d17fe4 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ACLPropertiesSplitter.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java > d270b13 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java > 82dd7df > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java > f80d6e5 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrAliasDao.java > d78ff0da > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java > da76924 > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ACLHandler.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ReloadCollectionHandler.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/SolrZkRequestHandler.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java > PRE-CREATION > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java > fa6162a > > ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSaslUsersZkCommand.java > b144b41 > ambari-logsearch/docker/bin/start.sh 81c9e66 > ambari-logsearch/docker/test-config/logsearch/logsearch-https.properties > 1bd8c70 > ambari-logsearch/docker/test-config/logsearch/logsearch.properties 71c1a1c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > 9ff9c74 > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py > 33ac715 > > Diff: https://reviews.apache.org/r/55429/diff/ > > > Testing > ------- > > done. mostly manually > > > Thanks, > > Oliver Szabo > >
