-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55523/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko and Di Li.
Bugs: AMBARI-19535
https://issues.apache.org/jira/browse/AMBARI-19535
Repository: ambari
Description
-------
When you click on a Group and view its details, sometimes the Type shows an
empty value.
The following error can be seen on the web console.
vendor.js:22245 TypeError: Cannot read property 'LABEL_KEY' of undefined at
main.js:2278 at wrappedCallback (vendor.js:23746) at vendor.js:23832 at
Scope.$eval (vendor.js:24875) at Scope.$digest (vendor.js:24687) at
Scope.$apply (vendor.js:24979) at done (vendor.js:20552) at completeRequest
(vendor.js:20766) at XMLHttpRequest.xhr.onreadystatechange (vendor.js:20705)
This is happenening because the REST call that fetches group type details
(getGroupType) does not always return before the groupTypeName is set in
getMembers.
To fix this, moved the code for setting groupTypeName to the getGroupType
method. The groupTypeName is now set once the group type has been retrieved by
the REST call.
Diffs
-----
ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js
aa6af2a
Diff: https://reviews.apache.org/r/55523/diff/
Testing
-------
Manual testing.
Ran mvn test.
Thanks,
Sangeeta Ravindran
