----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55529/#review161632 -----------------------------------------------------------
ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py (line 160) <https://reviews.apache.org/r/55529/#comment232899> Recommendation class ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py (line 182) <https://reviews.apache.org/r/55529/#comment232900> The logic in these functions was copied from older HDP stacks. ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py (line 259) <https://reviews.apache.org/r/55529/#comment232901> I can move this into stack advisor. ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py (line 356) <https://reviews.apache.org/r/55529/#comment232902> Validator class ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py (line 379) <https://reviews.apache.org/r/55529/#comment232903> Example ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py (line 95) <https://reviews.apache.org/r/55529/#comment232906> This can now be used by service advisors. ambari-server/src/main/resources/stacks/stack_advisor.py (line 884) <https://reviews.apache.org/r/55529/#comment232904> This method was moved from HDP 2.0.6 stack advisor to the default stack advisor. ambari-server/src/main/resources/stacks/stack_advisor.py (line 1052) <https://reviews.apache.org/r/55529/#comment232905> New method. - Alejandro Fernandez On Jan. 14, 2017, 1:37 a.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55529/ > ----------------------------------------------------------- > > (Updated Jan. 14, 2017, 1:37 a.m.) > > > Review request for Ambari, Andrew Onischuk, Dmitro Lisnichenko, Sumit > Mohanty, and Sid Wagle. > > > Bugs: AMBARI-19097 > https://issues.apache.org/jira/browse/AMBARI-19097 > > > Repository: ambari > > > Description > ------- > > Create a Service Advisor script for HDFS in HDP 3.0 Tech Preview. > The Service Advisor must encapsulate all of the logic inherited/overwritten > from HDP 2.0.6 through HDP 2.6 > > > Diffs > ----- > > > ambari-server/src/main/resources/common-services/HDFS/3.0.0.3.0/service_advisor.py > PRE-CREATION > > ambari-server/src/main/resources/common-services/ZOOKEEPER/3.4.9/service_advisor.py > 82316f4 > > ambari-server/src/main/resources/stacks/BIGTOP/0.8/services/stack_advisor.py > 5172042 > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py > 9b217b3 > ambari-server/src/main/resources/stacks/HDP/2.1/services/stack_advisor.py > 6ae29cb > ambari-server/src/main/resources/stacks/HDP/2.2/services/stack_advisor.py > b601179 > > ambari-server/src/main/resources/stacks/HDPWIN/2.1/services/stack_advisor.py > 4e4ef51 > > ambari-server/src/main/resources/stacks/HDPWIN/2.2/services/stack_advisor.py > 26292d9 > ambari-server/src/main/resources/stacks/stack_advisor.py d648a53 > ambari-server/src/test/python/TestStackAdvisor.py 87d2d15 > ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py > 355e211 > ambari-server/src/test/python/stacks/2.1/common/test_stack_advisor.py > f9fb1f5 > > Diff: https://reviews.apache.org/r/55529/diff/ > > > Testing > ------- > > Verified recommendation and validation of HDFS while deploying HDP 3.0 > > Python unit tests passed. > > Total run:1157 > Total errors:0 > Total failures:0 > OK > > > Thanks, > > Alejandro Fernandez > >
