----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55492/#review161784 -----------------------------------------------------------
Ship it! Ship It! - Robert Nettleton On Jan. 13, 2017, 10:52 a.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55492/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2017, 10:52 a.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-19519 > https://issues.apache.org/jira/browse/AMBARI-19519 > > > Repository: ambari > > > Description > ------- > > Log Feeder should not put the passwords of the keystore/truststore in the > command line, as it may be visible to others. Instead it should be in a file, > just like for Log Search Portal. > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/LogFeeder.java > 6d0f22c > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java > PRE-CREATION > ambari-logsearch/ambari-logsearch-logfeeder/src/main/scripts/run.sh 5aecd00 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 5ffd5e6 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logfeeder.py > 14f8d20 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py > 9ff9c74 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 > 6795dab > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py > 02570e2 > ambari-server/src/test/python/stacks/2.4/configs/default.json 30e12e9 > > Diff: https://reviews.apache.org/r/55492/diff/ > > > Testing > ------- > > Tested on local cluster > > > Thanks, > > Miklos Gergely > >
