> On Jan. 17, 2017, 3:57 p.m., Oliver Szabo wrote: > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py, > > line 356 > > <https://reviews.apache.org/r/55622/diff/1/?file=1606551#file1606551line356> > > > > im not sure is that will be right behaviour, in case of metrics uses > > https, then we will need to setup keystores for every logfeeder on the > > cluster (because that is not auto generated), maybe its better approach, if > > the metrics publish is failing in case of ssl is not enabled for logfeeder > > and metrics uses that (or put a message about that in the logfeeder log. > > e.g.: we wont send metrics because logfeeder ssl is not configured)
just because logfeeder_use_ssl is true it doesn't mean that we must set up trust stores. If the path specified is not existing, than everything will be OK except that there are no metrics published, this variable only gives the opportunity to use the trust store specified if it is there - Miklos ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55622/#review161878 ----------------------------------------------------------- On Jan. 17, 2017, 2:44 p.m., Miklos Gergely wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55622/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2017, 2:44 p.m.) > > > Review request for Ambari, Oliver Szabo and Robert Nettleton. > > > Bugs: AMBARI-19587 > https://issues.apache.org/jira/browse/AMBARI-19587 > > > Repository: ambari > > > Description > ------- > > Also fixed metrics handling in general as it had a bug. > > > Diffs > ----- > > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/metrics/LogFeederAMSClient.java > 2bdd7c9 > > ambari-logsearch/ambari-logsearch-logfeeder/src/main/java/org/apache/ambari/logfeeder/util/SSLUtil.java > 317f5ae > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java > d19db3c > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py > 25e947d > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logfeeder-env.sh.j2 > 6d1c445 > > ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/properties/logsearch-env.sh.j2 > 338c7f7 > > ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog250Test.java > 3c5b475 > ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logfeeder.py > b172f64 > > Diff: https://reviews.apache.org/r/55622/diff/ > > > Testing > ------- > > Tested on local cluster > > > Thanks, > > Miklos Gergely > >
