> On Jan. 17, 2017, 7:25 p.m., DIPAYAN BHOWMICK wrote: > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js, > > line 140 > > <https://reviews.apache.org/r/55516/diff/1/?file=1605028#file1605028line140> > > > > Can we conditional ternary operator as an expression and change the > > code like: > > > > res.start = res.total > 0 ? start : 0; > > > > Looks, much cleaner to me.
Thanks Dipayan. Uploaded the patch with the suggested change. - Sangeeta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55516/#review161916 ----------------------------------------------------------- On Jan. 17, 2017, 9:45 p.m., Sangeeta Ravindran wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55516/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2017, 9:45 p.m.) > > > Review request for Ambari, Di Li, DIPAYAN BHOWMICK, and Nitiraj Rathore. > > > Bugs: AMBARI-19475 > https://issues.apache.org/jira/browse/AMBARI-19475 > > > Repository: ambari > > > Description > ------- > > In the Workflow Manager View, when there are no co-ordinator or bundle > records, the dashboard message says "Showing 1 to 0 of 0 records". This is > because the start record is set to 1 by default. > > Fix is to set the start record to 0, if the total records is 0. > > > Diffs > ----- > > > contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js > 78bc1c9 > > Diff: https://reviews.apache.org/r/55516/diff/ > > > Testing > ------- > > Manual testing. > > > Thanks, > > Sangeeta Ravindran > >
