-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55429/
-----------------------------------------------------------

(Updated Jan. 18, 2017, 1:14 p.m.)


Review request for Ambari, Miklos Gergely and Robert Nettleton.


Changes
-------

- skip securing aliases.json


Bugs: AMBARI-19468
    https://issues.apache.org/jira/browse/AMBARI-19468


Repository: ambari


Description
-------

- added setAcl operation inside logsearch code
- added reload collection command (on schema or solrconfig change)
- removed logsearch solr client dependency
- refactor some methods to handlers in collection dao
- removed upload configurations call from ambari logsearch stack code.
- enable ACL security for Log Search / Infra Solr
- fixed jinja template generation in solr-client log4j config
- added global states (audit, service and config collection)
- added rest api filter based on global states
- create async upload config / check znode / collection creation / reloading / 
set acl commands
- removed collection dao and alias dao
- added status REST API for global states


Diffs (updated)
-----

  
ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py
 2e48c6a 
  ambari-logsearch/ambari-logsearch-portal/pom.xml 9d17fe4 
  
ambari-logsearch/ambari-logsearch-portal/src/main/configsets/audit_logs/conf/managed-schema
 4cd412b 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/common/ACLPropertiesSplitter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SecurityConfig.java
 c99a738 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrAuditLogPropsConfig.java
 d270b13 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConfig.java
 fb25a63 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrConnectionPropsConfig.java
 82dd7df 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/SolrPropsConfig.java
 f80d6e5 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrAuditLogsState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrCollectionState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrServiceLogsState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/conf/global/SolrUserConfigState.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/LogfeederFilterConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrAuditAliasConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrCollectionConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/configurer/SolrConfigurer.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/AuditSolrDao.java
 309687d 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/ServiceLogsSolrDao.java
 cf61163 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrAliasDao.java
 d78ff0da 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrCollectionDao.java
 da76924 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrDaoBase.java
 39b65ae 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/SolrSchemaFieldDao.java
 e6a562e 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/dao/UserConfigSolrDao.java
 106bedc 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/doc/DocConstants.java
 0fc9852 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ACLHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/CreateCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ListCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/ReloadCollectionHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/SolrZkRequestHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/handler/UploadConfigurationHandler.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/rest/StatusResource.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/AbstractLogsearchGlobalStateFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchAuditLogsStateFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchServiceLogsStateFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-portal/src/main/java/org/apache/ambari/logsearch/web/filters/LogsearchUserConfigStateFilter.java
 PRE-CREATION 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java
 fa6162a 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateSaslUsersZkCommand.java
 b144b41 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/SecureSolrZNodeZkCommand.java
 faa21d4 
  
ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/AclUtils.java
 8e0132d 
  ambari-logsearch/docker/bin/start.sh 81c9e66 
  ambari-logsearch/docker/test-config/logsearch/logsearch-https.properties 
1bd8c70 
  ambari-logsearch/docker/test-config/logsearch/logsearch.properties 71c1a1c 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/infra_solr.py
 532be47 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/params.py
 946cf15 
  
ambari-server/src/main/resources/common-services/AMBARI_INFRA/0.1.0/package/scripts/setup_infra_solr.py
 740c560 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py
 5ffd5e6 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/service_check.py
 30a1cda 
  
ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py
 9ff9c74 
  ambari-server/src/test/python/stacks/2.3/ATLAS/test_metadata_server.py 
f2fec70 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 33ac715 
  ambari-server/src/test/python/stacks/2.5/ATLAS/test_atlas_server.py 584763d 
  ambari-server/src/test/python/stacks/2.5/RANGER/test_ranger_admin.py 8e8e68b 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-default.json 
4510f4b 
  ambari-server/src/test/python/stacks/2.5/configs/ranger-admin-secured.json 
9144f12 
  ambari-server/src/test/python/stacks/2.6/RANGER/test_ranger_admin.py 32219b3 
  ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-default.json 
e517e3a 
  ambari-server/src/test/python/stacks/2.6/configs/ranger-admin-secured.json 
a04f9f8 

Diff: https://reviews.apache.org/r/55429/diff/


Testing
-------

done. mostly manually


Thanks,

Oliver Szabo

Reply via email to