> On Jan. 18, 2017, 9:31 p.m., Sid Wagle wrote:
> > ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java,
> > line 210
> > <https://reviews.apache.org/r/55663/diff/1/?file=1607344#file1607344line210>
> >
> > How come this does not throw any exception or catch any? With that I am
> > guessing null context is also ok as behavior.
userContext is initialized to empty map so results in "userContext" : {}
> On Jan. 18, 2017, 9:31 p.m., Sid Wagle wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py,
> > line 1055
> > <https://reviews.apache.org/r/55663/diff/1/?file=1607348#file1607348line1055>
> >
> > Minor nit: non-pythonic syntax here:
> >
> > if getOldValue(..) or .. and ..
Fixed.
- Sumit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55663/#review162180
-----------------------------------------------------------
On Jan. 18, 2017, 5:54 a.m., Sumit Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55663/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 5:54 a.m.)
>
>
> Review request for Ambari, Jayush Luniya, Swapan Shridhar, and Sid Wagle.
>
>
> Bugs: AMBARI-19546
> https://issues.apache.org/jira/browse/AMBARI-19546
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add support for call context to the stack advisor. This is a limited
> enhancements to differentiate between basic contenxts. Most importantly
> cluster create vs config edit vs add service and calls to get only the
> attributes.
>
> Two key changes:
> Differentiate between recommendComponentLayout, validateComponentLayout,
> recommendConfigurations, recommendConfigurationDependencies, and
> validateConfigurations. The key ones to differentiate are
> recommendConfigurations and recommendConfigurationDependencies. This change
> is committed already.
>
> Second is to distinguish between, clusterCreate, addService, and
> computeAttribute. All three are recommendConfigurations calls. Why it
> matters? During clusterCreate, stack advisor is free to compute any config
> properties it can. However, during addService and computeAttributes it should
> use supplied configs and then compute only what is needed.
>
> The patch has changes for blueprint deployments and the infra for UI to add
> the context as needed.
>
>
> Diffs
> -----
>
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorBlueprintProcessor.java
> 67dfded
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/StackAdvisorRequest.java
> b804c7e
>
> ambari-server/src/main/java/org/apache/ambari/server/api/services/stackadvisor/commands/StackAdvisorCommand.java
> 6f612af
>
> ambari-server/src/main/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProvider.java
> 0ad9126
> ambari-server/src/main/resources/properties.json b7e0988
> ambari-server/src/main/resources/scripts/stack_advisor.py 56bd34a
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/stack_advisor.py
> 968a94f
> ambari-server/src/main/resources/stacks/stack_advisor.py 6b29bc3
>
> ambari-server/src/test/java/org/apache/ambari/server/controller/internal/StackAdvisorResourceProviderTest.java
> e3b89b8
> ambari-server/src/test/python/stacks/2.0.6/common/test_stack_advisor.py
> f39703c
>
> Diff: https://reviews.apache.org/r/55663/diff/
>
>
> Testing
> -------
>
> Ran all unit tests (python and java locally)
>
>
> Thanks,
>
> Sumit Mohanty
>
>
