-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55615/#review162270
-----------------------------------------------------------




contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
197)
<https://reviews.apache.org/r/55615/#comment233612>

    we should send next request only when first call returns.



contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js (line 
211)
<https://reviews.apache.org/r/55615/#comment233611>

    you can check job failure as well in these situations


- Nitiraj Rathore


On Jan. 19, 2017, 11:24 a.m., Pallav Kulshreshtha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55615/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2017, 11:24 a.m.)
> 
> 
> Review request for Ambari, DIPAYAN BHOWMICK, Gaurav Nagar, Nitiraj Rathore, 
> and Rohit Choudhary.
> 
> 
> Bugs: AMBARI-19582
>     https://issues.apache.org/jira/browse/AMBARI-19582
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> UI changes for showing the logs and query results in separate tabs.
> 
> 
> Diffs
> -----
> 
>   contrib/views/hive20/src/main/resources/ui/app/adapters/query.js a666b09 
>   
> contrib/views/hive20/src/main/resources/ui/app/components/query-result-log.js 
> PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/models/worksheet.js 59395e6 
>   contrib/views/hive20/src/main/resources/ui/app/routes/queries/query.js 
> 606b71a 
>   contrib/views/hive20/src/main/resources/ui/app/services/jobs.js 723953c 
>   contrib/views/hive20/src/main/resources/ui/app/services/query.js 400f78b 
>   
> contrib/views/hive20/src/main/resources/ui/app/templates/components/query-result-log.hbs
>  PRE-CREATION 
>   contrib/views/hive20/src/main/resources/ui/app/templates/queries/query.hbs 
> 2138356 
> 
> Diff: https://reviews.apache.org/r/55615/diff/
> 
> 
> Testing
> -------
> 
> manually tested.
> 
> 
> Thanks,
> 
> Pallav Kulshreshtha
> 
>

Reply via email to